[ntp:questions] Re: ACTS - too many recvbufs allocated (40) (Correct the Version of ntp-dev)

[David L. Mills]

cipo,

I've increased the buffer size to 256; however, it should not have flung 
a fault in the first place. The code needs to be checked for boundaries. 
Thanks for the report.

Dave

cipo wrote:
> Hi,
> 
>> I've heard mixed reports. In the recent integration of USNO/NIST/PTB 
>> driver, the USNO and NIST formats were rigorously verified, but I 
>> could not verify the PTB format. I have heard at least one report that 
>> it works, then I hear your report that it doesn't. This is not hard to 
>> fix, but I can't do that from here. Someone needs to look at the 
>> sscanf call in the driver and compare with the PTB string actually 
>> received. The rcvbuf situation should have nothing to do with a 
>> possible format decoding bug.
>>  
>>
> In the refclock_acts.c, in the void acts_message(...) function, the buffer
> char tbuf[SMAX] is not enough for PTB like services. (SMAX = 80)
> The first sprintf(tbuf,"acts....) can cause segfault.
> Something like char tbuf[2*SMAX] works fine for me. Tested with PTB, 
> METAS, BEV.
> If the modem line quality is poor, (our case) the received buffer can be 
> more than the default 78 byte.
> Europian services officially support only 1200 baud. (ntp default is 9600.)
> Example log below:
> 
> acts: (5 15) 79 
> 2004-11-2.a.jéa╢O....U..$HL.832700000020041122125853331-50001220 Time 
> from #
> acts: (5 14) 78 2004-11-22 13:58:32 CET 
> 14832700000020041122125853331-50001221 M E T A S #
> acts: (5 13) 78 2004-11-22 13:5üA." CET 
> 14832700000020041122125853331-50001222 #
> acts: (5 12) 78 2004-11-22 13:58:34 CET 
> 14832700000020041122125853331-50001223 #
> acts: (5 11) 78 2004-11-22 13:58:35 CET 
> 14832700000020041122125853331-50001224==============#
> acts: (5 10) 83 2004-11-22 13:58:36 CET 
> 14832.¬≡$pe╡...c......a╢a....ja......ac.╡.....+.╓!.╓y_o..#
> acts: (5 9) 78 2004-11-22 13:58:37 CET 
> 14832700000020041122125853331-50001226 to stop code #
> acts: (5 8) 78 2004-11-22 13:58:38 CET 
> 14832700000020041122125853331-50001227and ? for help#
> acts: (5 7) 78 2004-11-22 13:58:39 CET 
> 14832700000020041122125853331-50001228==============#
> acts: (5 6) 78 2004-11-22 13:58:40 CET 
> 14832700000020041122125853331-50001220 Time from #
> acts: (5 5) 78 2004-11-22 13:58:41 CET 
> 14832700000020041122125853331-50001221 M E T A S #
> acts: (5 4) 78 2004-11-22 13:58:42 CET 
> 14832700000020041122125853331-50001222 #
> acts: (5 3) 78 2004-11-22 13:58:43 CET 
> 14832700000020041122125853331-50001223 #
> acts: (5 2) 79 2004-11-22 13:58:44 CET 
> 14832700°I2ôE..c......a╢a....ja......ceeeeeeeeeeeeeep#
> acts: (5 1) 78 2004-11-22 13:58:45 CET 
> 14832700000020041122125853331-50001225Type 2 slashes#
> 
> -cipo
> 
>