[ntp:questions] Re: ACTS - too many recvbufs allocated (40) (Correct the Version of ntp-dev)

[Danny Mayer]

At 01:35 PM 2/10/2005, cipo wrote:
> >> to:
> >>          rb->recv_length =
> >>              read(fd, (char *)&rb->recv_space, (unsigned)i);
> >>
> >>          if (rb->recv_length <= 0 || errno != 0)
> >>          {
> >>                  netsyslog(LOG_ERR, "clock read fd %d: %m", fd);
> >>                  freerecvbuf(rb);
> >>                  goto select_again;
> >>          }
> >>
> >> This should take care of the problem. I will put a better fix into the
> >> sources over the next few days.
>
> >That addresses the symptom rather than the cause, which is a hangup
> >owing to carrier dropping.  With the above change in place, I'd expect
> >a continuous stream of "clock read" messages, CPU maxed, and no other
> >input will happen because "goto select_again" picks up the error condition
> >each time round and never does anything else.
>
>Yes, this happens (100% proc consumed, infinite select loop, no other 
>input) , as I wrote in some of my previous comments.

Yes, it's a problem with the tight double loop in input_handler().

Danny

>-cipo
>
>
>_______________________________________________
>questions mailing list
>questions at lists.ntp.isc.org
>https://lists.ntp.isc.org/mailman/listinfo/questions