[ntp:bugs] [Bug 1783] PPS range gate check throws away valid samples

[bugzilla-daemon at ntp.org]

https://bugs.ntp.org/show_bug.cgi?id=1783

Frank Kardel <kardel at ntp.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|VERIFIED                    |REOPENED
                 CC|                            |kardel at ntp.org
         Resolution|FIXED                       |

--- Comment #7 from Frank Kardel <kardel at ntp.org> 2011-03-17 18:09:04 UTC ---
The last 'fix' ntp_refclock.c:1.103 breaks things again.

===== ntp_refclock.c 1.102 vs 1.103 =====
1325a1326,1328
>       if (timeout.tv_sec == ap->ts.tv_sec)
>               return (0);
> 

This compares again tv_sec value. It is perfectly ok for a PPS timestamp
pattern to be like this:
5.0000001
6.0000002
6.9999997
8.0000001

Comparing tv_sec is wrong - if you want to avoid duplicates you need to compare
the respective serial numbers - this is probably what was intended.

Frank

-- 
Configure bugmail: https://bugs.ntp.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.