[ntp:bugs] [Bug 1783] PPS range gate check throws away valid samples

[bugzilla-daemon at ntp.org]

https://bugs.ntp.org/show_bug.cgi?id=1783

--- Comment #9 from Frank Kardel <kardel at ntp.org> 2011-03-17 18:39:18 UTC ---
Well, first of all the current code is wrong - that must be fixed.

Secondly, the sequence numbers are part of the PPSAPI RFC-2783. It is not wrong
to use these to
detect duplicates and missed samples. It is the sole point for these sequence
numbers.

Your notion that ntpd never depended on PPSAPI sequence numbers in only true if
you don't consider following refclocks being part of ntpd:
jupiter
mx4200
oncore
parse
ripencc

So to resolve the issue we must either have a correct rangegate implementation
(Dave just removed the wrong implementation without any replacement). Or, we
remember sequence numbers to detect duplicates.

Frank

-- 
Configure bugmail: https://bugs.ntp.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.