[ntp:hackers] Re: Latest change to ntp_config.c broke NetBSD

Frederick Bruckman fredb at immanent.net
Wed Jul 30 19:01:32 PDT 2003


On Wed, 30 Jul 2003, Danny Mayer wrote:

> At 04:36 PM 7/30/03, Frederick Bruckman wrote:
> >Danny,
> >
> >Your last two changes to ntp_config.c broke ntpd on NetBSD,
> >both 1.6U and 1.6.1. Every attempt to send a packet puts
> >
> >   sendto(__peer__): Can't assign requested address
> >
> >in the syslog, and "ntpq -c pe" doesn't show any peers, though
> >"ntpdc -c dmp" does. Reverting just that, like so,
> >
> >   bk get -p -r at 1.1126 ntpd/ntp_config.c > ntpd/ntp_config.c
> >
> >fixes it. I haven't yet tried to factor out the exact thing
> >that breaks it, but looking at the diff, you no longer set
> >hints.ai_socktype to SOCK_DGRAM. Was that intentional?

> No, it wasn't intentional. It comes of working on multiple machines in two
> different places at the same time. I had noticed this last night but I didn't
> have time to fix it again. bk merges can be annoying. I'm fixing this now.

I suspected as much.

I've worked out that the thing that actually makes it fail on NetBSD
is calling getaddrinfo() there with NULL for the service name. I can't
say exactly why. The rest of your change causes no problems.

Frederick



More information about the hackers mailing list