[ntp:hackers] PPS, PPSAPI and pps_sample()
David L. Mills
mills at udel.edu
Mon Dec 13 20:45:34 PST 2004
The routine reports already are tagged. The syslog messages already go
to a common routine. Only the refclock syslog messages may be ambiguous,
but there are 400 of them. It is probably quite rare in the scheme of
things that multiple instantiations of the same device driver are
configured and even in those cases (admittedly like ours) if one
instantiation sends a syslog, they all will. Syslog messages are
generally not sent unless something real bad comes down and that usually
will require more ambitions debugging infrastructure, like a debug trace.
I'll put that in the todo list, but quite far from the top.
Danny Mayer wrote:
> If these are common messages except for the name of the refclock
> they really should go into a common function and get called
> appropriately from the refclock. That would make the code much
> more maintainable.
> At 07:48 PM 12/13/2004, David L. Mills wrote:
>> The refclock_report() and other interface routines already report the
>> clock address. The same thing could be done for the syslog messages,
>> but to be consistent would require changing by my count about 400
>> syslog messages in almost four dozen clock drivers and related code.
>> Do we have a volunteer?
More information about the hackers