[ntp:hackers] Suggestions for getting a patch accepted smoothly?

Nelson B Bolyard nelson at bolyard.me
Thu May 6 18:31:08 UTC 2010


Greetings,

I'm nearly done developing a patch to the sntp client source code that
is part of the source code distribution from ntp.org.  I seek advice on
how to get that patch through the procedures and processes that lead to
it being accepted into that distribution in a timely fashion.

My patch is intended to fully and correctly implement sntp authentication,
implementing the -a and -k command line options, and broadcast/multicast
feature (the -b option), the timeout feature (the -t option), and correctly
implement the parsing of v4 extensions in sntp responses (should there ever
be any :).  It addresses these bugs:

https://bugs.ntp.org/show_bug.cgi?id=1325
https://bugs.ntp.org/show_bug.cgi?id=1459

I'm nearly done. I'm just working out some details about the extension
parsing now, and I'm hoping to test with at least one live ntpd server that
does MD5 or SHA1 authentication.  The patch affects only 5 source files, but
is a pretty major overhaul of one of them (networking.c).

What should I do to get this patch through the process, once it's ready?
Any suggestions?
Attach the patch as a diff -pu to the bug and request someone to review it?
who?  anything else?

/Nelson Bolyard  (Mozilla open source developer, RFC 4492 co-author)


More information about the hackers mailing list