[ntp:hackers] Suggestions for getting a patch accepted smoothly?

Dave Hart davehart at gmail.com
Thu May 6 18:54:05 UTC 2010


On Thu, May 6, 2010 at 6:31 PM, Nelson B Bolyard <nelson at bolyard.me> wrote:
> Greetings,
>
> I'm nearly done developing a patch to the sntp client source code that
> is part of the source code distribution from ntp.org.  I seek advice on
> how to get that patch through the procedures and processes that lead to
> it being accepted into that distribution in a timely fashion.
>
> My patch is intended to fully and correctly implement sntp authentication,
> implementing the -a and -k command line options, and broadcast/multicast
> feature (the -b option), the timeout feature (the -t option), and correctly
> implement the parsing of v4 extensions in sntp responses (should there ever
> be any :).  It addresses these bugs:
>
> https://bugs.ntp.org/show_bug.cgi?id=1325
> https://bugs.ntp.org/show_bug.cgi?id=1459

Thanks for your efforts, this sounds great.

> I'm nearly done. I'm just working out some details about the extension
> parsing now, and I'm hoping to test with at least one live ntpd server that
> does MD5 or SHA1 authentication.

All you need to do then is set up ntpd with MD5 and/or SHA keys in a
keyfile.  You can configure both types with different key IDs and test
each in turn with sntp.  Make sure the keys IDs are listed after
trustedkey in ntp.conf.

> The patch affects only 5 source files, but
> is a pretty major overhaul of one of them (networking.c).
>
> What should I do to get this patch through the process, once it's ready?
> Any suggestions?
> Attach the patch as a diff -pu to the bug and request someone to review it?
> who?  anything else?

I would be one prospect to review it.  Doing as you suggest is great.
If you would prefer more private feedback first I'm happy to take a
look at it.

Cheers,
Dave Hart


More information about the hackers mailing list